Global Styles: clean cached data when switching themes #30830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
This was referenced Apr 14, 2021
so new data can be recalculated for the new one.
oandregal
force-pushed
the
fix/clean-cached-data
branch
from
02d84b7
to
65b68de
Compare
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
|
Pushed tests for this so it's ready for review. |
oandregal
commented
Apr 14, 2021
| * | ||
| * @var Array | ||
| */ | ||
| private static $theme_json_i18n = null; |
There was a problem hiding this comment.
This was extracted out to the class so it can be cleaned upon theme switches.
ockham
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Thanks @nosolosw! This does seem like a good solution 💯
I have a minor concern about maintainability -- if other static fields were to be added to this class, people would need to remember to reset them in clean_cached_data(). But I can't come up with a good alternative, and it seems acceptable 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30478
Alternative to #30479
This PR hooks into the
switch_themeaction to clean the cached data, so it can be recalculated for the new theme. This is especially important for unit tests.